Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Issue 646103005: Fix Function::Clone() and Field::Clone() to adjust the class owner of type (Closed)

Created:
6 years, 1 month ago by regis
Modified:
6 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix Function::Clone() and Field::Clone() to adjust the class owner of type parameters (issue 18630). Add regression tests. Commented out 3 lines in mirror test (issue 21474 filed). R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=41424

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -7 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 5 chunks +15 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 7 chunks +95 lines, -3 lines 0 comments Download
A tests/language/mixin_type_parameter5_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A tests/language/mixin_type_parameter6_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M tests/lib/mirrors/mirrors_reader.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
regis
6 years, 1 month ago (2014-10-29 19:59:21 UTC) #2
srdjan
lgtm
6 years, 1 month ago (2014-10-29 20:14:05 UTC) #3
regis
6 years, 1 month ago (2014-10-30 17:39:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r41424 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698