Scaffolding for testing incremental compilation.

Scaffolding for testing incremental compilation.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41070

[ahe, 2014-10-09 10:38:26]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2014-10-10 10:28:56]

lgtm

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/increment...
File dart/tests/try/web/incremental_compilation_update.html (right):

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/increment...
dart/tests/try/web/incremental_compilation_update.html:28: /// with
Window.postMessage and used to communicate between the this iframe
'the this' -> 'this'.

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/increment...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/increment...
dart/tests/try/web/incremental_compilation_update_test.dart:30: ..style.height =
'90vh';
Out of curiosity: What does the 'vw' and 'vh' suffixes mean?

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/sandbox.dart
File dart/tests/try/web/sandbox.dart (right):

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/sandbox.d...
dart/tests/try/web/sandbox.dart:5: /// Helper library that creates an iframe
sandbox for that can be used to load
'for that' -> 'that'.

[ahe, 2014-10-10 11:05:04]

Thank you, Johnni!

I'll upload a new patch set when I have addressed the typos. This is just a
quick reply to your question.

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/increment...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/increment...
dart/tests/try/web/incremental_compilation_update_test.dart:30: ..style.height =
'90vh';
On 2014/10/10 10:28:56, Johnni Winther wrote:
> Out of curiosity: What does the 'vw' and 'vh' suffixes mean?

Viewport width and viewport height.

[ahe, 2014-10-13 11:47:36]

Thank you, Johnni!

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/increment...
File dart/tests/try/web/incremental_compilation_update.html (right):

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/increment...
dart/tests/try/web/incremental_compilation_update.html:28: /// with
Window.postMessage and used to communicate between the this iframe
On 2014/10/10 10:28:56, Johnni Winther wrote:
> 'the this' -> 'this'.

Done.

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/sandbox.dart
File dart/tests/try/web/sandbox.dart (right):

https://codereview.chromium.org/645513002/diff/1/dart/tests/try/web/sandbox.d...
dart/tests/try/web/sandbox.dart:5: /// Helper library that creates an iframe
sandbox for that can be used to load
On 2014/10/10 10:28:56, Johnni Winther wrote:
> 'for that' -> 'that'.

Done.

[ahe, 2014-10-13 12:06:47]

Committed patchset #4 (id:120001) manually as 41070 (presubmit successful).