Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 644473003: combinator suggestion fix and more common tests (Closed)

Created:
6 years, 2 months ago by danrubel
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

combinator suggestion fix and more common tests BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40998

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -92 lines) Patch
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 2 chunks +23 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 4 chunks +103 lines, -17 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 4 chunks +2 lines, -48 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 2 months ago (2014-10-08 20:09:12 UTC) #2
scheglov
lgtm
6 years, 2 months ago (2014-10-08 20:20:53 UTC) #3
danrubel
6 years, 2 months ago (2014-10-08 20:38:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698