Issue 64383004: Re-mark directory_watcher/mac_os_test as passing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 64383004: Re-mark directory_watcher/mac_os_test as passing. (Closed)

Created:
7 years, 1 month ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-mark directory_watcher/mac_os_test as passing. As before, this test is expected to fail. It's only failing on the bots so we need to get the debug information from the bots to figure out how to fix it. This also adds some additional debug information to help clarify some confusing output from the most recent failing log. R=rnystrom@google.com BUG=15024 Committed: https://code.google.com/p/dart/source/detail?r=30315

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -23 lines)			Patch
M	pkg/pkg.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/watcher/lib/src/directory_watcher/mac_os.dart	View	11 chunks	+36 lines, -22 lines	0 comments	Download
M	pkg/watcher/test/utils.dart	View	3 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

7 years, 1 month ago (2013-11-15 21:43:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30315 (presubmit successful).

Expand Messages | Collapse Messages