Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 643763002: Make "error" the default severity for checked mode compile time errors. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Make "error" the default severity for checked mode compile time errors. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java View 1 chunk +5 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/ErrorType.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-09 21:46:04 UTC) #2
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-09 21:49:10 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-09 21:57:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41030 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698