Issue 64373003: pkg/csslib: types, fixes, cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 64373003: pkg/csslib: types, fixes, cleanup (Closed)

Created:
7 years, 1 month ago by kevmoo-old

Modified:
7 years, 1 month ago

Reviewers:
terry, Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -141 lines)			Patch
M	pkg/csslib/bin/css.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/csslib/lib/src/css_printer.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/csslib/lib/src/tree.dart	View	1	56 chunks	+102 lines, -103 lines	0 comments	Download
M	pkg/csslib/lib/src/tree_base.dart	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/csslib/lib/src/tree_printer.dart	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/csslib/lib/src/validate.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/csslib/lib/visitor.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A	pkg/csslib/test/debug_test.dart	View		1 chunk	+30 lines, -0 lines	0 comments	Download
M	pkg/csslib/test/declaration_test.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/csslib/test/error_test.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/csslib/test/run_all.dart	View		1 chunk	+8 lines, -7 lines	0 comments	Download
M	pkg/csslib/test/selector_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/csslib/test/testing.dart	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	pkg/csslib/test/visitor_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

kevmoo-old

Started using this on the widget project and found some issues I don't think this ...

7 years, 1 month ago (2013-11-07 14:18:45 UTC) #1

terry

Kevin LGTM - nice cleanup. Not much has been done to csslib for the last ...

7 years, 1 month ago (2013-11-07 14:43:35 UTC) #2

kevmoo-old

7 years, 1 month ago (2013-11-07 14:46:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30049 (presubmit successful).