Issue 64363003: Fix Android build and disable profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 64363003: Fix Android build and disable profiler (Closed)

Created:
7 years, 1 month ago by Cutch

Modified:
7 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Android build and disable profiler TBR Committed: https://code.google.com/p/dart/source/detail?r=30428

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	runtime/vm/profiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/signal_handler.h	View		1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #1 manually as r30428 (presubmit successful).

7 years, 1 month ago (2013-11-19 23:25:36 UTC) #2

zra

7 years, 1 month ago (2013-11-19 23:39:01 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/64363003/diff/1/runtime/vm/signal_handler.h
File runtime/vm/signal_handler.h (right):

https://codereview.chromium.org/64363003/diff/1/runtime/vm/signal_handler.h#n...
runtime/vm/signal_handler.h:16: #include <sys/sigcontext.h>  // NOLINT
The build still fails.

I think asm/sigcontext.h was right, and the type in it is "struct sigcontext".

Expand Messages | Collapse Messages