Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 643293002: Fix x64 build (RBX is callee-saved, use R8 instead). (Closed)

Created:
6 years, 2 months ago by regis
Modified:
6 years, 2 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix x64 build (RBX is callee-saved, use R8 instead). Committed: https://code.google.com/p/dart/source/detail?r=41053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/vm/assembler_x64_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
TBR Interestingly, this did not crash without the change of r41049.
6 years, 2 months ago (2014-10-10 20:43:00 UTC) #1
regis
TBR Interestingly, this did not crash without the change of r41049.
6 years, 2 months ago (2014-10-10 20:43:28 UTC) #3
regis
Committed patchset #1 (id:1) manually as r41053 (presubmit successful).
6 years, 2 months ago (2014-10-10 20:43:52 UTC) #4
zra
6 years, 2 months ago (2014-10-10 20:47:14 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698