dart2js: Emit constants in new emitter.

dart2js: Emit constants in new emitter.

Currently the constants are still emitted eagerly, but it should be relatively straightforward to switch to a lazy emission.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41144

[floitsch, 2014-10-15 20:32:10]

floitsch@google.com changed reviewers:
+ kasperl@google.com

[floitsch, 2014-10-15 20:32:11]

Depends on https://codereview.chromium.org/649873003/

[kasperl, 2014-10-16 07:01:57]

LGTM.

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_emitter/model.dart (right):

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/model.dart:19: * This class
represents a JavaScript object that containts static state, like
containts -> contains

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
File
sdk/lib/_internal/compiler/implementation/js_emitter/new_emitter/model_emitter.dart
(right):

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/new_emitter/model_emitter.dart:186:
return new js.Block(constants.map((Constant constant) {
I'd add a local variable to make this easier to parse.

  Iterable statements = constants.map((Constant constant) {

  });
  return new js.Block(statements.toList());

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart
(right):

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart:125:
List<Constant> _buildConstants(List<ConstantValue> constantValues) {
Should this be _buildConstantsForFragment to avoid repeating the
_task.outputConstantLists[fragment.outputUnit]) code?

[floitsch, 2014-10-16 12:59:54]

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_emitter/model.dart (right):

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/model.dart:19: * This class
represents a JavaScript object that containts static state, like
On 2014/10/16 07:01:56, kasperl wrote:
> containts -> contains

Done.

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
File
sdk/lib/_internal/compiler/implementation/js_emitter/new_emitter/model_emitter.dart
(right):

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/new_emitter/model_emitter.dart:186:
return new js.Block(constants.map((Constant constant) {
On 2014/10/16 07:01:56, kasperl wrote:
> I'd add a local variable to make this easier to parse.
> 
>   Iterable statements = constants.map((Constant constant) {
> 
>   });
>   return new js.Block(statements.toList());
>   

Done.

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart
(right):

https://codereview.chromium.org/642813005/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart:125:
List<Constant> _buildConstants(List<ConstantValue> constantValues) {
On 2014/10/16 07:01:57, kasperl wrote:
> Should this be _buildConstantsForFragment to avoid repeating the
> _task.outputConstantLists[fragment.outputUnit]) code?

Done.

[floitsch, 2014-10-16 13:00:15]

Committed patchset #3 (id:40001) manually as 41144 (presubmit successful).