Issue 642693005: Revert "IR refactoring: reduce duplication related to MayThrow/AllowsCSE."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 642693005: Revert "IR refactoring: reduce duplication related to MayThrow/AllowsCSE." (Closed)

Created:
6 years, 2 months ago by Vyacheslav Egorov (Chromium)

Modified:
6 years, 2 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "IR refactoring: reduce duplication related to MayThrow/AllowsCSE." This reverts commit r41281. Old Mac OS X bots are unhappy (GCC frontend used on those bots can't correctly resolve reference to the base constructor unless all template parameters are specified). R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41284

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+690 lines, -280 lines)			Patch
	M	runtime/vm/intermediate_language.h	View		219 chunks	+672 lines, -274 lines	0 comments	Download
	M	runtime/vm/intermediate_language.cc	View		6 chunks	+18 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

Committed patchset #1 (id:1) manually as 41284 (presubmit successful).

6 years, 2 months ago (2014-10-24 16:06:06 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages