Remove the need for functionSignature.

Remove the need for functionSignature.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41067

[Johnni Winther, 2014-10-10 09:05:33]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-10-10 12:56:04]

LGTM.

https://codereview.chromium.org/641923003/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart
(right):

https://codereview.chromium.org/641923003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart:212:
name: name.moveNext() ? name.current : null,
Minor nit. (not much better. just wanted to point it out).
could be simplified to:
name.moveNext();
defaultValue.moveNext();
element.moveNext();
return emitParameter(type, name.current, defaultValue.current, element.current);

The contract is that 'current' returns null when moveNext returned false.

https://codereview.chromium.org/641923003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart:221:
ParameterElement elementFromParameter(tree.Variable parameter) {
I prefer to inline it.
If it doesn't fit, I'm ok with taking a shorter name:
((p) => p.element)

Unless you want the type check.

And I would like to suggest an improvement to the spec:
(x) => x.foo should have as shortcut: *.foo
--
parameters.map(*.element)

[Johnni Winther, 2014-10-13 08:05:56]

Committed patchset #2 (id:110001) manually as 41067 (presubmit successful).

[Johnni Winther, 2014-10-13 08:10:55]

https://codereview.chromium.org/641923003/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart
(right):

https://codereview.chromium.org/641923003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart:212:
name: name.moveNext() ? name.current : null,
On 2014/10/10 12:56:04, floitsch wrote:
> Minor nit. (not much better. just wanted to point it out).
> could be simplified to:
> name.moveNext();
> defaultValue.moveNext();
> element.moveNext();
> return emitParameter(type, name.current, defaultValue.current,
element.current);
> 
> The contract is that 'current' returns null when moveNext returned false.

Done. I thought [current] would throw!

https://codereview.chromium.org/641923003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart:221:
ParameterElement elementFromParameter(tree.Variable parameter) {
On 2014/10/10 12:56:04, floitsch wrote:
> I prefer to inline it.
> If it doesn't fit, I'm ok with taking a shorter name:
> ((p) => p.element)
> 
> Unless you want the type check.
> 
> And I would like to suggest an improvement to the spec:
> (x) => x.foo should have as shortcut: *.foo
> --
> parameters.map(*.element)

Done.