Issue 64173005: Deoptimize closure functions in DeoptimizeWorld. This was causing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 64173005: Deoptimize closure functions in DeoptimizeWorld. This was causing (Closed)

Created:
7 years, 1 month ago by turnidge

Modified:
7 years, 1 month ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Deoptimize closure functions in DeoptimizeWorld. This was causing some breakpoints to be skipped when set in optimized closure functions. Update implicit_closure_function() to always return null for factories. Factories use the shared data_ field for another purpose. This fixes an assertion failure when HasImplicitClosureFunciton is called for a factory. Add a TODO for an assertion failure in Class::Name which is not in the scope of this change. (patched from an earlier review) Committed: https://code.google.com/p/dart/source/detail?r=30063