Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 641413002: Substitute type parameters when evaluating const literal maps/lists. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Substitute type parameters when evaluating const literal maps/lists. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -14 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 2 chunks +24 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +116 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-10 17:37:16 UTC) #2
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-10 17:47:45 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-10 18:12:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41046 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698