Issue 64113002: Update NSS to Chromium revision 232552

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 64113002: Update NSS to Chromium revision 232552 (Closed)

Created:
7 years, 1 month ago by Bill Hesse

Modified:
7 years, 1 month ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update NSS to Chromium revision 232552 BUG= R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=30044

Patch Set 2 : Test with assert failure passes in release mode. #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -19 lines)			Patch
M	runtime/bin/net/nss.gyp	View		6 chunks	+21 lines, -5 lines	0 comments	Download
M	runtime/bin/net/sqlite.gyp	View		5 chunks	+30 lines, -5 lines	1 comment	Download
M	runtime/bin/net/ssl.gyp	View		3 chunks	+11 lines, -7 lines	0 comments	Download
M	runtime/bin/net/zlib.gyp	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

https://codereview.chromium.org/64113002/diff/1/runtime/bin/net/zlib.gyp File runtime/bin/net/zlib.gyp (left): https://codereview.chromium.org/64113002/diff/1/runtime/bin/net/zlib.gyp#oldcode129 runtime/bin/net/zlib.gyp:129: # Changed by Dart: Omit target 'zip' This change ...

7 years, 1 month ago (2013-11-07 10:06:29 UTC) #1

Anders Johnsen

lgtm https://codereview.chromium.org/64113002/diff/40001/runtime/bin/net/sqlite.gyp File runtime/bin/net/sqlite.gyp (right): https://codereview.chromium.org/64113002/diff/40001/runtime/bin/net/sqlite.gyp#newcode209 runtime/bin/net/sqlite.gyp:209: # Include a dummy c++ file to force ...

7 years, 1 month ago (2013-11-07 11:55:55 UTC) #3

Bill Hesse

7 years, 1 month ago (2013-11-07 12:01:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r30044 (presubmit successful).

Expand Messages | Collapse Messages

Issue 64113002: Update NSS to Chromium revision 232552 (Closed)

Description

Patch Set 1 #

Patch Set 2 : Test with assert failure passes in release mode. #

Messages