Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Issue 640813004: Handle non-factory redirects in constant evaluation. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle non-factory redirects in constant evaluation. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 3 chunks +31 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest.dart View 2 chunks +196 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A tests/language/compile_time_constant_checked4_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-17 00:38:05 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-17 05:52:08 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-17 15:54:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41169 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698