Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 639293004: Verify correctness of classes derived from Enum. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Verify correctness of classes derived from Enum. Now that the analyzer code is no longer being translated from Javascript, we have to maintain the enum classes manually. These tests will help avoid mistakes. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41080

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -0 lines) Patch
A pkg/analyzer/test/enum_test.dart View 1 chunk +359 lines, -0 lines 1 comment Download
M pkg/analyzer/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Paul Berry
6 years, 2 months ago (2014-10-13 18:21:38 UTC) #2
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-13 18:43:28 UTC) #3
scheglov
LGTM
6 years, 2 months ago (2014-10-13 19:06:33 UTC) #4
Paul Berry
Committed patchset #1 (id:1) manually as 41080 (presubmit successful).
6 years, 2 months ago (2014-10-13 20:02:34 UTC) #5
ricow1
https://codereview.chromium.org/639293004/diff/1/pkg/analyzer/test/enum_test.dart File pkg/analyzer/test/enum_test.dart (right): https://codereview.chromium.org/639293004/diff/1/pkg/analyzer/test/enum_test.dart#newcode346 pkg/analyzer/test/enum_test.dart:346: 'Getters $name and ${ordinals[value.ordinal]} have ordinal value ${value.ordinal}'); long ...
6 years, 2 months ago (2014-10-14 09:08:10 UTC) #7
ricow1
6 years, 2 months ago (2014-10-14 09:09:57 UTC) #9
Message was sent while issue was closed.
+floitsch
This is failing on dart2js compiled output
see e.g.:
http://build.chromium.org/p/client.dart/builders/dart2js-linux-release-minifi...

Powered by Google App Engine
This is Rietveld 408576698