Issue 638903004: Fix incorrect handling of refined aliases during load forwarding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 638903004: Fix incorrect handling of refined aliases during load forwarding. (Closed)

Created:
6 years, 2 months ago by Vyacheslav Egorov (Google)

Modified:
6 years, 2 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix incorrect handling of refined aliases during load forwarding. If intrablock load forwarding refines some store instruction in a way that introduces previously unseen alias fallback to unrefined place with a more generic alias instead. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41009

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		2 chunks	+21 lines, -0 lines	0 comments	Download
	M	tests/language/vm/load_to_load_forwarding_vm_test.dart	View		2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

6 years, 2 months ago (2014-10-09 11:47:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41009 (presubmit successful).

Expand Messages | Collapse Messages