Issue 63883006: Fill in blanks for Event docs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63883006: Fill in blanks for Event docs. (Closed)

Created:
7 years, 1 month ago by Andrei Mouravski

Modified:
7 years, 1 month ago

Reviewers:
Kathy Walrath

CC:
reviews_dartlang.org, blois

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fill in blanks for Event docs. Committed: https://code.google.com/p/dart/source/detail?r=30319

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -0 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+42 lines, -0 lines	2 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+42 lines, -0 lines	0 comments	Download
M	tools/dom/docs/docs.json	View	1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

Committed patchset #1 manually as r30319 (presubmit successful).

7 years, 1 month ago (2013-11-15 22:18:00 UTC) #2

Kathy Walrath

7 years, 1 month ago (2013-11-18 22:13:41 UTC) #3

Message was sent while issue was closed.

one link should be fixed, otherwise lgtm.

https://codereview.chromium.org/63883006/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/63883006/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:12042: +   * * [Target phase]
(http://www.w3.org/TR/DOM-Level-3-Events/#target-phase)
Global (but not a big deal):

- It seems a little overkill-ish to have a header inside a 2-line description.

- It seems weird to have the space between the ] and (.
   It works, but it's just not how we usually do links.

https://codereview.chromium.org/63883006/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:12067: +   * * [Bubble phase]
(http://www.w3.org/TR/DOM-Level-3-Events/#bubble-phase)
Bubble -> Capturing

(in the text and in the URL)

Expand Messages | Collapse Messages