Don't create unused OSError in Socket_Available.

Don't create unused OSError in Socket_Available.

BUG=
R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41005

[Anders Johnsen, 2014-10-09 06:05:22]

ajohnsen@google.com changed reviewers:
+ iposva@google.com, sgjesse@google.com

[Ivan Posva, 2014-10-09 06:12:07]

LGTM

-Ivan

https://codereview.chromium.org/638303002/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/638303002/diff/1/runtime/bin/socket_patch.dar...
runtime/bin/socket_patch.dart:578: }
available = (avail != null) avail : 1;

With the same comment about forcing the read from the socket as in the other
place nativeAvailable is called. Alternatively we could just have the native
code return a 1 instead of null. Removing the need for this adjustment.

https://codereview.chromium.org/638303002/diff/1/runtime/bin/socket_patch.dar...
runtime/bin/socket_patch.dart:756: available = 1;
ditto.

[Anders Johnsen, 2014-10-09 06:17:07]

ptal, let me know if this gets too implicit.

https://codereview.chromium.org/638303002/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/638303002/diff/1/runtime/bin/socket_patch.dar...
runtime/bin/socket_patch.dart:578: }
On 2014/10/09 06:12:07, Ivan Posva wrote:
> available = (avail != null) avail : 1;
> 
> With the same comment about forcing the read from the socket as in the other
> place nativeAvailable is called. Alternatively we could just have the native
> code return a 1 instead of null. Removing the need for this adjustment.

Done.

https://codereview.chromium.org/638303002/diff/1/runtime/bin/socket_patch.dar...
runtime/bin/socket_patch.dart:756: available = 1;
On 2014/10/09 06:12:07, Ivan Posva wrote:
> ditto.

Done.

[Ivan Posva, 2014-10-09 06:21:01]

LGTM -ip

[Anders Johnsen, 2014-10-09 06:21:27]

Committed patchset #3 (id:40001) manually as 41005 (presubmit successful).

[Søren Gjesse, 2014-10-09 06:47:29]

lgtm