Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 637683002: Remove the last external import in protocol. (Closed)

Created:
6 years, 2 months ago by scheglov
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove the last external import in protocol. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M pkg/analysis_server/lib/src/protocol.dart View 2 chunks +13 lines, -2 lines 0 comments Download
D pkg/analysis_server/lib/src/services/json.dart View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 2 months ago (2014-10-07 21:47:15 UTC) #1
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-07 22:03:36 UTC) #2
scheglov
6 years, 2 months ago (2014-10-07 22:11:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40982 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698