Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issue 637633003: Enable mirrors for all the classes in the analyzer tests. (Closed)

Created:
6 years, 2 months ago by scheglov
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enable mirrors for all the classes in the analyzer tests. Othewise dart2js cannot find these classes. I've tried to annotate *Test classes only with ReflectiveTestCase, but practically, because almost all the methods are test_*, we end up having reflection information for almost all methods. So, for simplicity let's just enable it for everything. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M pkg/analyzer/test/reflective_tests.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 2 months ago (2014-10-07 21:08:03 UTC) #1
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-07 21:10:27 UTC) #2
scheglov
6 years, 2 months ago (2014-10-07 21:18:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40980 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698