Type check constant variable declarations.

Type check constant variable declarations.

BUG=dartbug.com/16391
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41054

[Paul Berry, 2014-10-10 21:00:22]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2014-10-10 21:23:45]

LGTM

https://codereview.chromium.org/637303005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/637303005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/error.dart:467: "The object type '{0}' cannot be
assigned to a variable of type '{1}'");
"variable" --> "const variable"?

It might be more obvious to the user what's going on if the message indicates
that this is only an error because the variable is a 'const'. Or possibly
something explicit about the fact that there will be a run-time exception. (My
concern is that users will look at the types in question and be confused because
super types can be assigned to subtypes.

[Paul Berry, 2014-10-10 21:56:38]

https://codereview.chromium.org/637303005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/637303005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/error.dart:467: "The object type '{0}' cannot be
assigned to a variable of type '{1}'");
On 2014/10/10 21:23:45, Brian Wilkerson wrote:
> "variable" --> "const variable"?
> 
> It might be more obvious to the user what's going on if the message indicates
> that this is only an error because the variable is a 'const'. Or possibly
> something explicit about the fact that there will be a run-time exception. (My
> concern is that users will look at the types in question and be confused
because
> super types can be assigned to subtypes.

Good point.  I've added a TODO comment for now.  I'll loop back and think about
how to wordsmith the messages once I've discovered all the situations where we
need to report errors like this.

[Paul Berry, 2014-10-10 21:57:23]

Committed patchset #1 (id:1) manually as 41054 (presubmit successful).