Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 637003002: Convert all the generated tests to reflective. (Closed)

Created:
6 years, 2 months ago by scheglov
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Convert all the generated tests to reflective. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -19786 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest.dart View 49 chunks +50 lines, -4131 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 15 chunks +17 lines, -1701 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 23 chunks +24 lines, -1859 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 8 chunks +11 lines, -4243 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 34 chunks +35 lines, -6977 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 6 chunks +8 lines, -862 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 3 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 2 months ago (2014-10-07 18:10:28 UTC) #1
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-07 19:41:15 UTC) #2
scheglov
6 years, 2 months ago (2014-10-07 19:48:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40974 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698