Issue 636903003: A tentative step into converting analyzer tests into reflective.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 636903003: A tentative step into converting analyzer tests into reflective. (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

A tentative step into converting analyzer tests into reflective. We don't generate / translate tests anymore, so managing dartSuite() manually is quite labor-consuming. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40964

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1283 lines)			Patch
	M	pkg/analyzer/test/generated/element_test.dart	View		15 chunks	+18 lines, -1284 lines	0 comments	Download
	A +	pkg/analyzer/test/reflective_tests.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 4 (0 generated)

Brian Wilkerson

I don't like the fact that we're copying reflective_tests.dart. Not necessarily for this CL, but ...

6 years, 2 months ago (2014-10-07 17:18:20 UTC) #3

scheglov

6 years, 2 months ago (2014-10-07 17:27:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40964 (presubmit successful).