Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 636313002: Add "checked mode compile time error" type to analysis server API. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add "checked mode compile time error" type to analysis server API. This avoids a crash if the analyzer detects a checked mode compile time error. R=brianwilkerson@google.com, danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=41000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisErrorType.java View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 3 chunks +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-08 20:22:00 UTC) #2
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-08 20:25:42 UTC) #3
danrubel
lgtm
6 years, 2 months ago (2014-10-08 20:34:25 UTC) #4
Paul Berry
6 years, 2 months ago (2014-10-08 20:52:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41000 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698