Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 636153003: more common code completion tests (Closed)

Created:
6 years, 2 months ago by danrubel
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

more common code completion tests BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40995

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -293 lines) Patch
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 4 chunks +222 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 2 chunks +0 lines, -59 lines 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 1 chunk +0 lines, -179 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 2 months ago (2014-10-08 16:25:34 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-08 17:05:41 UTC) #3
danrubel
6 years, 2 months ago (2014-10-08 17:56:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698