Properly parse jsshell and d8 stack frames.

Properly parse jsshell and d8 stack frames.

It turns out jsshell and d8 can use native paths where Firefox and
Chrome usually use URLs. This CL accommodates that.

R=rnystrom@google.com
BUG=14897
Committed: https://code.google.com/p/dart/source/detail?r=30079

[Bob Nystrom, 2013-11-07 22:25:09]

I think this should handle UNC paths too. Otherwise, LGTM.

https://codereview.chromium.org/63603005/diff/1/pkg/stack_trace/lib/src/frame...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/63603005/diff/1/pkg/stack_trace/lib/src/frame...
pkg/stack_trace/lib/src/frame.dart:226: static final _windowsRegExp = new
RegExp(r'^[a-zA-Z]:[\/]');
What about UNC paths?

https://codereview.chromium.org/63603005/diff/1/pkg/stack_trace/test/frame_te...
File pkg/stack_trace/test/frame_test.dart (right):

https://codereview.chromium.org/63603005/diff/1/pkg/stack_trace/test/frame_te...
pkg/stack_trace/test/frame_test.dart:91: });
Add a UNC path test too.

[nweiz, 2013-11-07 22:40:11]

https://codereview.chromium.org/63603005/diff/1/pkg/stack_trace/lib/src/frame...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/63603005/diff/1/pkg/stack_trace/lib/src/frame...
pkg/stack_trace/lib/src/frame.dart:226: static final _windowsRegExp = new
RegExp(r'^[a-zA-Z]:[\/]');
On 2013/11/07 22:25:10, Bob Nystrom wrote:
> What about UNC paths?

They were implicitly supported by the uriOrPath.contains('\') case, but I've
added more explicit support.

https://codereview.chromium.org/63603005/diff/1/pkg/stack_trace/test/frame_te...
File pkg/stack_trace/test/frame_test.dart (right):

https://codereview.chromium.org/63603005/diff/1/pkg/stack_trace/test/frame_te...
pkg/stack_trace/test/frame_test.dart:91: });
On 2013/11/07 22:25:10, Bob Nystrom wrote:
> Add a UNC path test too.

Done.

[nweiz, 2013-11-07 22:41:47]

Committed patchset #2 manually as r30079 (presubmit successful).