Issue 635393002: Fix Object::Clone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 635393002: Fix Object::Clone. (Closed)

Created:
6 years, 2 months ago by koda

Modified:
6 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix Object::Clone. Exclude header when copying: default value for its tags will be that of a fresh object. Correct logic for adding the clone to the store buffer. BUG=21273 Committed: https://code.google.com/p/dart/source/detail?r=41055

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -18 lines)			Patch
	M	runtime/vm/object.h	View	1 2	2 chunks	+3 lines, -2 lines	1 comment	Download
	M	runtime/vm/object.cc	View	1	1 chunk	+23 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -Ivan https://codereview.chromium.org/635393002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/635393002/diff/1/runtime/vm/object.cc#newcode1755 runtime/vm/object.cc:1755: memmove(reinterpret_cast<uint8_t*>(clone_addr) + kHeaderSizeInBytes, Address calculation on uword ...

6 years, 2 months ago (2014-10-10 20:59:04 UTC) #2

koda

6 years, 2 months ago (2014-10-10 23:27:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as r41055 (presubmit successful).

Expand Messages | Collapse Messages