Fix some users of removed mirror API.

Fix some users of removed mirror API.

R=gbracha@google.com, jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30016

[Jennifer Messerly, 2013-11-06 23:55:57]

polymer changes lgtm, thank you!

[gbracha, 2013-11-07 00:09:10]

I think there a couple of buglets in here. See comments.

https://codereview.chromium.org/63483002/diff/30001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/63483002/diff/30001/pkg/docgen/lib/docgen.dar...
pkg/docgen/lib/docgen.dart:584: }
Could we make this function shared library-wide (private of course)?

https://codereview.chromium.org/63483002/diff/30001/pkg/docgen/lib/docgen.dar...
pkg/docgen/lib/docgen.dart:595: _methods(filterMap(mirror.declarations, (d) => d
is MethodMirror)),
This now gets you constructors that were not in the original

https://codereview.chromium.org/63483002/diff/30001/pkg/docgen/test/single_li...
File pkg/docgen/test/single_library_test.dart (right):

https://codereview.chromium.org/63483002/diff/30001/pkg/docgen/test/single_li...
pkg/docgen/test/single_library_test.dart:118: var methodMirror =
classMirror.declarations['doThis'];
#doThis?

https://codereview.chromium.org/63483002/diff/30001/tools/dom/src/native_DOMI...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/63483002/diff/30001/tools/dom/src/native_DOMI...
tools/dom/src/native_DOMImplementation.dart:305: addAll(mirror.declarations,
isStatic);
This adds constructors, which were not there before I think

[rmacnak, 2013-11-07 00:18:29]

https://codereview.chromium.org/63483002/diff/30001/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/63483002/diff/30001/pkg/docgen/lib/docgen.dar...
pkg/docgen/lib/docgen.dart:584: }
On 2013/11/07 00:09:11, gbracha wrote:
> Could we make this function shared library-wide (private of course)?

Done.

https://codereview.chromium.org/63483002/diff/30001/pkg/docgen/lib/docgen.dar...
pkg/docgen/lib/docgen.dart:595: _methods(filterMap(mirror.declarations, (d) => d
is MethodMirror)),
On 2013/11/07 00:09:11, gbracha wrote:
> This now gets you constructors that were not in the original

Fixed.

https://codereview.chromium.org/63483002/diff/30001/pkg/docgen/test/single_li...
File pkg/docgen/test/single_library_test.dart (right):

https://codereview.chromium.org/63483002/diff/30001/pkg/docgen/test/single_li...
pkg/docgen/test/single_library_test.dart:118: var methodMirror =
classMirror.declarations['doThis'];
On 2013/11/07 00:09:11, gbracha wrote:
> #doThis?

Actually, undoing this change. These aren't dart:mirrors.

https://codereview.chromium.org/63483002/diff/30001/tools/dom/src/native_DOMI...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/63483002/diff/30001/tools/dom/src/native_DOMI...
tools/dom/src/native_DOMImplementation.dart:305: addAll(mirror.declarations,
isStatic);
On 2013/11/07 00:09:11, gbracha wrote:
> This adds constructors, which were not there before I think

And type variables. This is for auto-complete, so this may actually be a good
thing.

[gbracha, 2013-11-07 00:20:55]

lgtm

[rmacnak, 2013-11-07 00:25:01]

Committed patchset #4 manually as r30016 (presubmit successful).