Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 634653002: add named constructor, cascade selector suggestions and more tests (Closed)

Created:
6 years, 2 months ago by danrubel
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add named constructor, cascade selector suggestions and more tests BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40954

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Patch Set 3 : cleanup merge #

Patch Set 4 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -86 lines) Patch
M pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 2 chunks +51 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 1 2 3 7 chunks +104 lines, -58 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 3 chunks +17 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 2 chunks +56 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 5 chunks +94 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 2 chunks +70 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
6 years, 2 months ago (2014-10-06 21:30:38 UTC) #2
scheglov
LGTM https://codereview.chromium.org/634653002/diff/1/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart (right): https://codereview.chromium.org/634653002/diff/1/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart#newcode202 pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:202: element.getAncestor((parent) => parent is LibraryElement); element.library
6 years, 2 months ago (2014-10-06 21:36:14 UTC) #3
danrubel
https://codereview.chromium.org/634653002/diff/1/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart (right): https://codereview.chromium.org/634653002/diff/1/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart#newcode202 pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:202: element.getAncestor((parent) => parent is LibraryElement); On 2014/10/06 21:36:14, scheglov ...
6 years, 2 months ago (2014-10-07 12:42:01 UTC) #4
danrubel
6 years, 2 months ago (2014-10-07 12:43:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 40954 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698