Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 63393004: Work around issue 11901 in stack_trace. (Closed)

Created:
7 years, 1 month ago by nweiz
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Work around issue 11901 in stack_trace. For some reason, timer_impl.dart in dart:async has the incorrect URL in VM stack traces. This adds manual handling for that in the stack_trace package. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M pkg/stack_trace/lib/src/frame.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 1 month ago (2013-11-15 02:17:32 UTC) #1
Bob Nystrom
lgtm
7 years, 1 month ago (2013-11-15 18:10:29 UTC) #2
nweiz
7 years, 1 month ago (2013-11-15 22:16:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30318 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698