Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 63393003: Drop "Impl" suffix from local mirror class names. (Closed)

Created:
7 years, 1 month ago by rmacnak
Modified:
7 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Drop "Impl" suffix from local mirror class names. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -112 lines) Patch
M runtime/lib/mirrors.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 25 chunks +86 lines, -89 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
7 years, 1 month ago (2013-11-14 22:55:12 UTC) #1
siva
lgtm
7 years, 1 month ago (2013-11-15 22:13:12 UTC) #2
rmacnak
7 years, 1 month ago (2013-11-15 22:44:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30321 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698