Issue 21233. Improve inlining strings into string interpolations.

Issue 21233. Improve inlining strings into string interpolations.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21233

Committed: https://code.google.com/p/dart/source/detail?r=40963

[Paul Berry, 2014-10-07 01:14:56]

https://codereview.chromium.org/633823002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/inline_local.dart (right):

https://codereview.chromium.org/633823002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/inline_local.dart:156:
codeForReference = utils.getText(initOffset, initLength);
I think there will be a problem if the two strings are quoted differently, e.g.:

  String s1 = '"';
  String s2 = "$s1";

Inline s1 =>

  String s2 = """;

[Brian Wilkerson, 2014-10-07 14:02:54]

LGTM once Paul's comments are addressed.

[scheglov, 2014-10-07 16:24:24]

PTAL

https://codereview.chromium.org/633823002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/inline_local.dart (right):

https://codereview.chromium.org/633823002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/inline_local.dart:156:
codeForReference = utils.getText(initOffset, initLength);
On 2014/10/07 01:14:56, Paul Berry wrote:
> I think there will be a problem if the two strings are quoted differently,
e.g.:
> 
>   String s1 = '"';
>   String s2 = "$s1";
> 
> Inline s1 =>
> 
>   String s2 = """;

Done.

[Brian Wilkerson, 2014-10-07 16:38:23]

LGTM

[Paul Berry, 2014-10-07 17:12:39]

lgtm with comment addressed.

https://codereview.chromium.org/633823002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/services/refactoring/inline_local.dart (right):

https://codereview.chromium.org/633823002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/services/refactoring/inline_local.dart:155:
(initializer.isSingleQuoted || target.isMultiline)) {
I think you mean (!initializer.isMultiline || target.isMultiline).

[scheglov, 2014-10-07 17:21:44]

Committed patchset #3 (id:40001) manually as 40963 (presubmit successful).

[scheglov, 2014-10-07 17:22:06]

https://codereview.chromium.org/633823002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/services/refactoring/inline_local.dart (right):

https://codereview.chromium.org/633823002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/services/refactoring/inline_local.dart:155:
(initializer.isSingleQuoted || target.isMultiline)) {
On 2014/10/07 17:12:39, Paul Berry wrote:
> I think you mean (!initializer.isMultiline || target.isMultiline).

Ouch!
Thank you for catching this.

Test added and fixed.