Add support for working with large files, in dart:io.

Add support for working with large files on unix systems, in dart:io.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30399

[Søren Gjesse, 2013-11-19 10:15:49]

LGTM for POSIX.

https://codereview.chromium.org/63363010/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/63363010/diff/1/runtime/bin/bin.gypi#newcode128
runtime/bin/bin.gypi:128: '-D_FILE_OFFSET_BITS=64',
Does Windows use this as well? If not we should only define this for the
platforms that uses it.

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc
File runtime/bin/file_win.cc (right):

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc#newco...
runtime/bin/file_win.cc:77: return lseek(handle_->fd(), 0, SEEK_CUR);
Looking in the Windows docs
(http://msdn.microsoft.com/en-us/library/1yee101t(v=vs.100).aspx) we should use
_lseek64 here.

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc#newco...
runtime/bin/file_win.cc:83: return (lseek(handle_->fd(), position, SEEK_SET) !=
-1);
ditto

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc#newco...
runtime/bin/file_win.cc:89: return (chsize(handle_->fd(), length) != -1);
Use _chsize_s here
(http://msdn.microsoft.com/en-us/library/whx354w1(v=vs.100).aspx).

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc#newco...
runtime/bin/file_win.cc:102: if (fstat(handle_->fd(), &st) == 0) {
And _fstat64 (http://msdn.microsoft.com/en-us/library/221w8e43(v=vs.100).aspx).

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc#newco...
runtime/bin/file_win.cc:328: int stat_status = _wstat(system_name, &st);
_wstat64

[Anders Johnsen, 2013-11-19 10:43:39]

https://codereview.chromium.org/63363010/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/63363010/diff/1/runtime/bin/bin.gypi#newcode128
runtime/bin/bin.gypi:128: '-D_FILE_OFFSET_BITS=64',
On 2013/11/19 10:15:49, Søren Gjesse wrote:
> Does Windows use this as well? If not we should only define this for the
> platforms that uses it.

Wasn't needed anymore. Removed.

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc
File runtime/bin/file_win.cc (right):

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc#newco...
runtime/bin/file_win.cc:77: return lseek(handle_->fd(), 0, SEEK_CUR);
On 2013/11/19 10:15:49, Søren Gjesse wrote:
> Looking in the Windows docs
> (http://msdn.microsoft.com/en-us/library/1yee101t%28v=vs.100%29.aspx) we
should use
> _lseek64 here.

Done.

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc#newco...
runtime/bin/file_win.cc:83: return (lseek(handle_->fd(), position, SEEK_SET) !=
-1);
On 2013/11/19 10:15:49, Søren Gjesse wrote:
> ditto

Done.

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc#newco...
runtime/bin/file_win.cc:89: return (chsize(handle_->fd(), length) != -1);
On 2013/11/19 10:15:49, Søren Gjesse wrote:
> Use _chsize_s here
> (http://msdn.microsoft.com/en-us/library/whx354w1%28v=vs.100%29.aspx).

Done.

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc#newco...
runtime/bin/file_win.cc:102: if (fstat(handle_->fd(), &st) == 0) {
On 2013/11/19 10:15:49, Søren Gjesse wrote:
> And _fstat64
(http://msdn.microsoft.com/en-us/library/221w8e43%28v=vs.100%29.aspx).

Done.

https://codereview.chromium.org/63363010/diff/1/runtime/bin/file_win.cc#newco...
runtime/bin/file_win.cc:328: int stat_status = _wstat(system_name, &st);
On 2013/11/19 10:15:49, Søren Gjesse wrote:
> _wstat64

Done.

[Søren Gjesse, 2013-11-19 11:36:41]

LGTM!

[Anders Johnsen, 2013-11-19 11:38:59]

Committed patchset #3 manually as r30399 (presubmit successful).

[zra, 2013-11-19 16:10:17]

I recommend reverting the Android changes, checking the NDK headers, and
reapplying.

Thanks!
Zach

https://codereview.chromium.org/63363010/diff/170001/runtime/bin/file_android.cc
File runtime/bin/file_android.cc (right):

https://codereview.chromium.org/63363010/diff/170001/runtime/bin/file_android...
runtime/bin/file_android.cc:91: return
TEMP_FAILURE_RETRY(ftruncate64(handle_->fd(), length) != -1);
This change is causing a build failure on Android.

https://codereview.chromium.org/63363010/diff/170001/runtime/bin/file_android...
runtime/bin/file_android.cc:128: int fd = TEMP_FAILURE_RETRY(open64(name, flags,
0666));
This change is causing a build failure on Android.

https://codereview.chromium.org/63363010/diff/170001/runtime/bin/file_android...
runtime/bin/file_android.cc:160: open64(name, O_RDONLY | O_CREAT | O_CLOEXEC,
0666));
This change is causing a build failure on Android.

[Anders Johnsen, 2013-11-19 16:23:40]

Fixes underway in https://codereview.chromium.org/76413003/.

https://codereview.chromium.org/63363010/diff/170001/runtime/bin/file_android.cc
File runtime/bin/file_android.cc (right):

https://codereview.chromium.org/63363010/diff/170001/runtime/bin/file_android...
runtime/bin/file_android.cc:91: return
TEMP_FAILURE_RETRY(ftruncate64(handle_->fd(), length) != -1);
On 2013/11/19 16:10:17, zra wrote:
> This change is causing a build failure on Android.

Done.

https://codereview.chromium.org/63363010/diff/170001/runtime/bin/file_android...
runtime/bin/file_android.cc:128: int fd = TEMP_FAILURE_RETRY(open64(name, flags,
0666));
On 2013/11/19 16:10:17, zra wrote:
> This change is causing a build failure on Android.

Done.

https://codereview.chromium.org/63363010/diff/170001/runtime/bin/file_android...
runtime/bin/file_android.cc:160: open64(name, O_RDONLY | O_CREAT | O_CLOEXEC,
0666));
On 2013/11/19 16:10:17, zra wrote:
> This change is causing a build failure on Android.

Done.