Issue 63363003: Cascaded mirror removal revert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63363003: Cascaded mirror removal revert. (Closed)

Created:
7 years, 1 month ago by rmacnak

Modified:
7 years, 1 month ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cascaded mirror removal revert. Committed: https://code.google.com/p/dart/source/detail?r=30024

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+297 lines, -386 lines)			Patch
	pkg/observe/lib/src/observable.dart	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	pkg/serialization/lib/src/serialization_rule.dart	View	1 chunk	+4 lines, -9 lines	0 comments	Download
	pkg/unittest/lib/mirror_matchers.dart	View	1 chunk	+1 line, -7 lines	0 comments	Download
	runtime/tests/vm/dart/mirrored_compilation_error_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
	tests/compiler/dart2js/message_kind_test.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	tests/lib/lib.status	View	4 chunks	+45 lines, -2 lines	0 comments	Download
	tests/lib/mirrors/basic_types_in_dart_core_test.dart	View	1 chunk	+10 lines, -10 lines	0 comments	Download
	tests/lib/mirrors/constructor_kinds_test.dart	View	3 chunks	+9 lines, -10 lines	0 comments	Download
M	tests/lib/mirrors/constructors_test.dart	View	2 chunks	+4 lines, -12 lines	0 comments	Download
	tests/lib/mirrors/equality_test.dart	View	2 chunks	+22 lines, -22 lines	0 comments	Download
	tests/lib/mirrors/fake_function_with_call_test.dart	View	2 chunks	+2 lines, -11 lines	0 comments	Download
	tests/lib/mirrors/generic_function_typedef_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
	tests/lib/mirrors/generic_type_mirror_test.dart	View	2 chunks	+14 lines, -14 lines	0 comments	Download
	tests/lib/mirrors/generics_substitution_test.dart	View	1 chunk	+3 lines, -6 lines	0 comments	Download
	tests/lib/mirrors/generics_test.dart	View	1 chunk	+5 lines, -4 lines	0 comments	Download
	tests/lib/mirrors/hierarchy_invariants_test.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/lib/mirrors/immutable_collections_test.dart	View	2 chunks	+24 lines, -12 lines	0 comments	Download
M	tests/lib/mirrors/inherit_field_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
	tests/lib/mirrors/initializing_formals_test.dart	View	10 chunks	+10 lines, -10 lines	0 comments	Download
M	tests/lib/mirrors/intercepted_class_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/lib/mirrors/lazy_static_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
	tests/lib/mirrors/libraries_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
	tests/lib/mirrors/library_metadata2_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
	tests/lib/mirrors/metadata_constructed_constant_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
	tests/lib/mirrors/metadata_test.dart	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	tests/lib/mirrors/method_mirror_properties_test.dart	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	tests/lib/mirrors/method_mirror_returntype_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/mirrors/method_mirror_source_test.dart	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	tests/lib/mirrors/mirrors_test.dart	View	2 chunks	+6 lines, -6 lines	0 comments	Download
	tests/lib/mirrors/mixin_application_test.dart	View	14 chunks	+26 lines, -43 lines	0 comments	Download
	tests/lib/mirrors/mixin_members_test.dart	View	1 chunk	+4 lines, -13 lines	0 comments	Download
M	tests/lib/mirrors/operator_test.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/lib/mirrors/parameter_metadata_test.dart	View	1 chunk	+13 lines, -13 lines	0 comments	Download
	tests/lib/mirrors/parameter_test.dart	View	4 chunks	+8 lines, -11 lines	0 comments	Download
M	tests/lib/mirrors/private_symbol_test.dart	View	2 chunks	+7 lines, -7 lines	0 comments	Download
	tests/lib/mirrors/reflect_model_test.dart	View	4 chunks	+12 lines, -44 lines	0 comments	Download
M	tests/lib/mirrors/reflect_runtime_type_test.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	tests/lib/mirrors/reflect_uninstantiated_class_test.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
	tests/lib/mirrors/regress_14304_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	tests/lib/mirrors/removed_api_test.dart	View	1 chunk	+0 lines, -37 lines	0 comments	Download
	tests/lib/mirrors/return_type_test.dart	View	2 chunks	+3 lines, -9 lines	0 comments	Download
	tests/lib/mirrors/static_test.dart	View	1 chunk	+5 lines, -5 lines	0 comments	Download
	tests/lib/mirrors/to_string_test.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
	tests/lib/mirrors/type_variable_owner_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

rmacnak

7 years, 1 month ago (2013-11-07 01:21:19 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r30024 (presubmit successful).

Expand Messages | Collapse Messages