cascade target fix and common test

cascade target fix and common test

BUG=
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40970

[danrubel, 2014-10-07 17:52:21]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2014-10-07 18:15:45]

lgtm

https://codereview.chromium.org/633153002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/imported_computer.dart
(right):

https://codereview.chromium.org/633153002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/imported_computer.dart:63: //
statement. Do not make suggestions for the variable name.
Actually it would be nice to propose variable names based on the type name.

For example for SimpleIdentifier: simpleIdentifier and identifier.

[danrubel, 2014-10-07 18:47:10]

On 2014/10/07 18:15:45, scheglov wrote:
> lgtm
> 
>
https://codereview.chromium.org/633153002/diff/1/pkg/analysis_server/lib/src/...
> File pkg/analysis_server/lib/src/services/completion/imported_computer.dart
> (right):
> 
>
https://codereview.chromium.org/633153002/diff/1/pkg/analysis_server/lib/src/...
> pkg/analysis_server/lib/src/services/completion/imported_computer.dart:63: //
> statement. Do not make suggestions for the variable name.
> Actually it would be nice to propose variable names based on the type name.
> 
> For example for SimpleIdentifier: simpleIdentifier and identifier.

Agreed and will do... in a subsequent CL.

[danrubel, 2014-10-07 18:54:40]

Committed patchset #2 (id:20001) manually as 40970 (presubmit successful).