Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 632553002: Make it easier to run engine tests (Closed)

Created:
6 years, 2 months ago by Brian Wilkerson
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M pkg/analyzer/test/error_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/test_all.dart View 1 chunk +33 lines, -0 lines 2 comments Download
M pkg/analyzer/test/parse_compilation_unit_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/analyzer/test/test_all.dart View 1 chunk +28 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
Add a couple of files that should allow us to run all of the engine ...
6 years, 2 months ago (2014-10-05 16:36:22 UTC) #2
scheglov
LGTM https://codereview.chromium.org/632553002/diff/1/pkg/analyzer/test/generated/test_all.dart File pkg/analyzer/test/generated/test_all.dart (right): https://codereview.chromium.org/632553002/diff/1/pkg/analyzer/test/generated/test_all.dart#newcode22 pkg/analyzer/test/generated/test_all.dart:22: group('file_system', () { Copy-paste detected! :-) https://codereview.chromium.org/632553002/diff/1/pkg/analyzer/test/test_all.dart File ...
6 years, 2 months ago (2014-10-05 16:42:38 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/632553002/diff/1/pkg/analyzer/test/generated/test_all.dart File pkg/analyzer/test/generated/test_all.dart (right): https://codereview.chromium.org/632553002/diff/1/pkg/analyzer/test/generated/test_all.dart#newcode22 pkg/analyzer/test/generated/test_all.dart:22: group('file_system', () { Done https://codereview.chromium.org/632553002/diff/1/pkg/analyzer/test/test_all.dart File pkg/analyzer/test/test_all.dart (right): https://codereview.chromium.org/632553002/diff/1/pkg/analyzer/test/test_all.dart#newcode20 ...
6 years, 2 months ago (2014-10-05 22:21:38 UTC) #4
Brian Wilkerson
6 years, 2 months ago (2014-10-05 22:22:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698