Printing a useful error message if a version field is a num

Printing a useful error message if a version field is a num

BUG= https://code.google.com/p/dart/issues/detail?id=21229

Example:
$ cat pubspec.yaml
name: Name
description: A sample command-line application
version: 1.0

$ pub get
Resolving dependencies...
Error on line 3, column 10 of pubspec.yaml: "version" field must have three numeric components: major, minor, and patch. Instead of "1.0", consider "1.0.0".
version: 1.0
         ^^^

also

$ cat pubspec.yaml
name: Name
description: A sample command-line application
version: 1

$ pub get
Resolving dependencies...
Error on line 3, column 10 of pubspec.yaml: "version" field must have three numeric components: major, minor, and patch. Instead of "1", consider "1.0.0".
version: 1
         ^

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40971

[srawlins, 2014-10-04 19:13:58]

srawlins@google.com changed reviewers:
+ rnystrom@google.com

[srawlins, 2014-10-04 19:13:58]

Hi Bob, would you mind reviewing? Feel free to reassign; I just saw your name on
all of the Pub issues :)

[Bob Nystrom, 2014-10-06 16:19:34]

I'm the right person to review this. For anything under sdk/lib/_internal/pub,
you can pick me and/or nweiz@ to review it. We are more or less interchangeable
when it comes to pub.

https://codereview.chromium.org/632483002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/632483002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/pubspec.dart:78: _error('"version" field must be
written in MAJOR.MINOR.PATCH[SUFFIX] format', span);
I think the all caps part might confuse users a bit. How about:

"version" field must have three numeric components: major, minor, and patch.
Instead of "$version", consider "$fixed".

where fixed is the original version with ".0.0" added if it's an int or ".0"
added if it is a float.

Also, long line.

[srawlins, 2014-10-06 17:33:08]

Thanks Bob, I've updated the description with the new output. Much more helpful.

https://codereview.chromium.org/632483002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/632483002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/pubspec.dart:78: _error('"version" field must be
written in MAJOR.MINOR.PATCH[SUFFIX] format', span);
On 2014/10/06 16:19:34, Bob Nystrom wrote:
> I think the all caps part might confuse users a bit. How about:
> 
> "version" field must have three numeric components: major, minor, and patch.
> Instead of "$version", consider "$fixed".
> 
> where fixed is the original version with ".0.0" added if it's an int or ".0"
> added if it is a float.
> 
> Also, long line.

Love it! Done.

[Bob Nystrom, 2014-10-06 17:35:53]

Have you uploaded the changes?

Also, tests please. You can add them to pub/test/pubspec_test.dart.

[srawlins, 2014-10-06 18:03:11]

Ooh thanks Bob. I didn't see there were error tests for pubspec. How do these
look?

[Bob Nystrom, 2014-10-06 19:21:10]

Two nits, then LGTM. Thanks!

https://codereview.chromium.org/632483002/diff/40001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/632483002/diff/40001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/pubspec.dart:78: String fixed = '$version.0';
We just use "var" for local variables.

https://codereview.chromium.org/632483002/diff/40001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/pubspec.dart:82: _error('"version" field must have
three numeric components: major, minor, '
Still just slightly too long. :)

https://codereview.chromium.org/632483002/diff/40001/sdk/lib/_internal/pub/te...
File sdk/lib/_internal/pub/test/pubspec_test.dart (right):

https://codereview.chromium.org/632483002/diff/40001/sdk/lib/_internal/pub/te...
sdk/lib/_internal/pub/test/pubspec_test.dart:251: });
Beautiful!

[srawlins, 2014-10-06 19:44:16]

https://codereview.chromium.org/632483002/diff/40001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/632483002/diff/40001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/pubspec.dart:78: String fixed = '$version.0';
On 2014/10/06 19:21:10, Bob Nystrom wrote:
> We just use "var" for local variables.

Done.

https://codereview.chromium.org/632483002/diff/40001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/pubspec.dart:82: _error('"version" field must have
three numeric components: major, minor, '
On 2014/10/06 19:21:10, Bob Nystrom wrote:
> Still just slightly too long. :)

Done.

https://codereview.chromium.org/632483002/diff/40001/sdk/lib/_internal/pub/te...
File sdk/lib/_internal/pub/test/pubspec_test.dart (right):

https://codereview.chromium.org/632483002/diff/40001/sdk/lib/_internal/pub/te...
sdk/lib/_internal/pub/test/pubspec_test.dart:251: });
On 2014/10/06 19:21:10, Bob Nystrom wrote:
> Beautiful!

Acknowledged.

[srawlins, 2014-10-07 18:55:12]

Committed patchset #5 (id:80001) manually as 40971 (presubmit successful).