Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 632353002: Add support for cross-session storage (Closed)

Created:
6 years, 2 months ago by Brian Wilkerson
Modified:
6 years, 2 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, lukechurch
Visibility:
Public.

Description

Add support for cross-session storage R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=40962

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -236 lines) Patch
M pkg/analyzer/lib/file_system/file_system.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +5 lines, -0 lines 1 comment Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 2 chunks +28 lines, -0 lines 4 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +250 lines, -236 lines 0 comments Download
M pkg/analyzer/test/file_system/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
https://codereview.chromium.org/632353002/diff/1/pkg/analyzer/lib/file_system/memory_file_system.dart File pkg/analyzer/lib/file_system/memory_file_system.dart (right): https://codereview.chromium.org/632353002/diff/1/pkg/analyzer/lib/file_system/memory_file_system.dart#newcode70 pkg/analyzer/lib/file_system/memory_file_system.dart:70: return newFolder('/user/home/$pluginId'); I'm tempted to use an invalid folder ...
6 years, 2 months ago (2014-10-07 15:55:23 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/632353002/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart File pkg/analyzer/lib/file_system/physical_file_system.dart (right): https://codereview.chromium.org/632353002/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart#newcode29 pkg/analyzer/lib/file_system/physical_file_system.dart:29: static final String SERVER_DIR = "dartServer"; On Mac ...
6 years, 2 months ago (2014-10-07 16:50:36 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/632353002/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart File pkg/analyzer/lib/file_system/physical_file_system.dart (right): https://codereview.chromium.org/632353002/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart#newcode29 pkg/analyzer/lib/file_system/physical_file_system.dart:29: static final String SERVER_DIR = "dartServer"; Done https://codereview.chromium.org/632353002/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart#newcode61 pkg/analyzer/lib/file_system/physical_file_system.dart:61: ...
6 years, 2 months ago (2014-10-07 16:57:51 UTC) #4
Brian Wilkerson
6 years, 2 months ago (2014-10-07 16:58:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 40962 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698