Add support in test scripts backend for simple HTML tests.

Add support in test scripts backend for simple HTML tests.

BUG=dartbug.com/20698
R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40956

[Bill Hesse, 2014-10-07 12:09:56]

whesse@google.com changed reviewers:
+ ricow@google.com

[Bill Hesse, 2014-10-07 12:09:56]

This is the back end of the new html tests.  The code for unit testing it is on
my machine, but will not be committed.

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:1687: if
(html_test.found_message_count == html_test.expected_messages.length) {
Long line fixed.

[ricow1, 2014-10-07 12:46:21]

A few comments, generally lgtm.
Should we have something similar to our normal debug timeouts that will ship
back the dom before we get killed as a timeout?

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:1403: } else if (nextTest is
HtmlTest){
add a toJSON to the BrowserTest and overwrite it in HtmlTest, remove type
testing here?

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:1674: if (typeof msg != 'string')
return;
what would this mean?

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:1680:
html_test.double_received_messages.push(msg);
I am thinking this could be an error (I am so beeping sick of the existing
double reporting tests, making this an error should at least make it better for
this category of tests)

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:1685: reportHtmlTestWarning();
same comment as above, or do we expect this?

[Bill Hesse, 2014-10-07 15:28:34]

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:1403: } else if (nextTest is
HtmlTest){
On 2014/10/07 12:46:21, ricow1 wrote:
> add a toJSON to the BrowserTest and overwrite it in HtmlTest, remove type
> testing here?

Done.

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:1674: if (typeof msg != 'string')
return;
On 2014/10/07 12:46:21, ricow1 wrote:
> what would this mean?

Apparently, things other than strings can be posted to the window.

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:1680:
html_test.double_received_messages.push(msg);
On 2014/10/07 12:46:21, ricow1 wrote:
> I am thinking this could be an error (I am so beeping sick of the existing
> double reporting tests, making this an error should at least make it better
for
> this category of tests)

Lets think about this.  It is easy to change.

https://codereview.chromium.org/632283002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:1685: reportHtmlTestWarning();
On 2014/10/07 12:46:21, ricow1 wrote:
> same comment as above, or do we expect this?

I think it might be more reasonable to expect this - some framework, or some new
library, could send messages to the window object, and the test should just
ignore them.  I know there is a comment that polymer sends doubles to the window
as messages - that is why we only look at strings.

[Bill Hesse, 2014-10-07 15:29:26]

Added DOM to status messages, and added periodic status message.

[Bill Hesse, 2014-10-07 15:29:47]

Committed patchset #2 (id:20001) manually as 40956 (presubmit successful).