More string literals getters.

More string literals getters.

To use in the inline local refactoring.

1. We can unwrap a literal only if its `isSingleQuoted` is the same as of the target literal.

2. We can unwrap a single-line literal into a multi-line one, but not vice versa.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=40957

[Paul Berry, 2014-10-07 13:18:04]

lgtm.  Your call on the comments.

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/ast.dart:16063: return
StringUtilities.endsWithChar(lexeme, 0x27);
Would it be better to check the beginning of the string rather than the end? 
This check will yield the wrong result if the string is unterminated.

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/ast.dart:16193: return
StringUtilities.endsWith3(lexeme, 0x22, 0x22, 0x22) ||
Similar concern here.

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/ast.dart:16205: return
StringUtilities.endsWithChar(lexeme, 0x27);
And here.

[Brian Wilkerson, 2014-10-07 14:12:04]

LGTM

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/ast.dart:16063: return
StringUtilities.endsWithChar(lexeme, 0x27);
> Would it be better to check the beginning of the string rather than the end? 
> This check will yield the wrong result if the string is unterminated.

isMultiline (on line 16049) has the same potential problem. We might want to
re-write it to check the start of the string as well. The reason I didn't
originally was to avoid having to handle raw strings differently.

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/ast_test.dart (right):

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/ast_test.dart:1745: void test_isMultiline() {
It wouldn't hurt to test this method with double-quoted strings.

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/ast_test.dart:1764: void test_isSingleQuoted() {
It wouldn't hurt to test this method with multi-line strings.

[scheglov, 2014-10-07 15:37:57]

PTAL

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/ast.dart:16063: return
StringUtilities.endsWithChar(lexeme, 0x27);
On 2014/10/07 13:18:04, Paul Berry wrote:
> Would it be better to check the beginning of the string rather than the end? 
> This check will yield the wrong result if the string is unterminated.

Done.

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/ast.dart:16063: return
StringUtilities.endsWithChar(lexeme, 0x27);
On 2014/10/07 14:12:04, Brian Wilkerson wrote:
> > Would it be better to check the beginning of the string rather than the end?

> > This check will yield the wrong result if the string is unterminated.
> 
> isMultiline (on line 16049) has the same potential problem. We might want to
> re-write it to check the start of the string as well. The reason I didn't
> originally was to avoid having to handle raw strings differently.

Done.

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/ast.dart:16193: return
StringUtilities.endsWith3(lexeme, 0x22, 0x22, 0x22) ||
On 2014/10/07 13:18:04, Paul Berry wrote:
> Similar concern here.

Done.

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/ast.dart:16205: return
StringUtilities.endsWithChar(lexeme, 0x27);
On 2014/10/07 13:18:04, Paul Berry wrote:
> And here.

Done.

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/ast_test.dart (right):

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/ast_test.dart:1745: void test_isMultiline() {
On 2014/10/07 14:12:04, Brian Wilkerson wrote:
> It wouldn't hurt to test this method with double-quoted strings.

Done.

https://codereview.chromium.org/632203002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/ast_test.dart:1764: void test_isSingleQuoted() {
On 2014/10/07 14:12:04, Brian Wilkerson wrote:
> It wouldn't hurt to test this method with multi-line strings.

Done.

[Brian Wilkerson, 2014-10-07 15:45:23]

LGTM

[scheglov, 2014-10-07 15:51:11]

Committed patchset #2 (id:20001) manually as 40957 (presubmit successful).

[Paul Berry, 2014-10-07 16:30:56]

lgtm with the "length < 3" issue addressed.

https://codereview.chromium.org/632203002/diff/20001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/632203002/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/ast.dart:16051: if (lexeme.length < 6) {
Change this to "if (lexeme.length < 3)".  Otherwise we won't correctly identify
incomplete multiline strings.

https://codereview.chromium.org/632203002/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/ast.dart:16056: if (lexeme.codeUnitAt(0) == 0x72)
{
Nit: for readability it would be nice to change this to "if (isRaw)".  Your call
though.

[scheglov, 2014-10-07 18:11:09]

https://codereview.chromium.org/632203002/diff/20001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/632203002/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/ast.dart:16051: if (lexeme.length < 6) {
On 2014/10/07 16:30:55, Paul Berry wrote:
> Change this to "if (lexeme.length < 3)".  Otherwise we won't correctly
identify
> incomplete multiline strings.

Pushed this change into another analyzer CL:
https://codereview.chromium.org/637003002