Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 632123002: Properly annotate type_check_const_function_typedef2_test. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly annotate type_check_const_function_typedef2_test. Rather than mark it as "Fail, OK" in the status files, annotate it as "checked mode compile-time error"; the test framework will convert this to a pass or fail expectation depending on whether the test is being run in checked mode. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=40955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M tests/language/language.status View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language_analyzer.status View 2 chunks +1 line, -2 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/type_check_const_function_typedef2_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-07 00:03:59 UTC) #2
Johnni Winther
LGTM. Nice catch!
6 years, 2 months ago (2014-10-07 07:07:57 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-07 13:23:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698