Issue 63173009: Ensure we run the observable transform on PolymerElement (fixes issue 14942)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63173009: Ensure we run the observable transform on PolymerElement (fixes issue 14942) (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
7 years, 1 month ago

Reviewers:
dgrove, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Ensure we run the observable transform on PolymerElement (fixes issue 14942) R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30089

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -631 lines)			Patch
M	pkg/observe/lib/transform.dart	View		1 chunk	+4 lines, -407 lines	0 comments	Download
A +	pkg/observe/lib/transformer.dart	View	1	2 chunks	+27 lines, -2 lines	0 comments	Download
M	pkg/observe/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
D	pkg/observe/test/transform_test.dart	View		1 chunk	+0 lines, -216 lines	0 comments	Download
A +	pkg/observe/test/transformer_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/pkg.status	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/lib/transformer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/pubspec.yaml	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Siggi Cherem (dart-lang)

This the fix we need to make pub-build consistent with build.dart --deploy. Should we cherry ...

7 years, 1 month ago (2013-11-08 00:06:40 UTC) #1

dgrove

I think we should not cherry-pick this. On 2013/11/08 00:07:46, John Messerly wrote: > lgtm

7 years, 1 month ago (2013-11-08 00:08:46 UTC) #3

Siggi Cherem (dart-lang)

7 years, 1 month ago (2013-11-08 00:33:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r30089 (presubmit successful).