Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1573)

Issue 631553002: Change integration test notifications to use structured objects. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change integration test notifications to use structured objects. This allows us to use completions when writing code to handle server notifications in integration tests. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -272 lines) Patch
M pkg/analysis_server/test/integration/analysis/error_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/highlights_test.dart View 3 chunks +60 lines, -47 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/navigation_test.dart View 2 chunks +60 lines, -37 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/occurrences_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/outline_test.dart View 2 chunks +19 lines, -19 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/overrides_test.dart View 3 chunks +21 lines, -17 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/reanalyze_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 15 chunks +57 lines, -56 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 20 chunks +93 lines, -69 lines 0 comments Download
M pkg/analysis_server/test/integration/server/status_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-06 00:28:49 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-06 00:35:27 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 40916 (presubmit successful).
6 years, 2 months ago (2014-10-06 01:05:03 UTC) #4
Brian Wilkerson
6 years, 2 months ago (2014-10-06 14:00:57 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698