Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 631123002: Swap getUsage() for get usage in args package (Closed)

Created:
6 years, 2 months ago by srawlins
Modified:
6 years, 1 month ago
Reviewers:
Bob Nystrom, tjblasi
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Bump args version, add to args CHANGELOG #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M pkg/args/CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/args/lib/src/arg_parser.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/args/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/args/test/usage_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
srawlins
Bob, are you also the de facto maintainer for args package? :D
6 years, 2 months ago (2014-10-07 06:46:22 UTC) #2
Bob Nystrom
I am the maintainer of args. :) The code changes look fine. In addition, you'll ...
6 years, 2 months ago (2014-10-07 15:55:38 UTC) #3
srawlins
On 2014/10/07 15:55:38, Bob Nystrom wrote: > I am the maintainer of args. :) > ...
6 years, 2 months ago (2014-10-07 17:43:12 UTC) #4
Bob Nystrom
LGTM!
6 years, 2 months ago (2014-10-07 17:44:24 UTC) #5
srawlins
Committed patchset #2 (id:20001) manually as 40966 (presubmit successful).
6 years, 2 months ago (2014-10-07 17:56:21 UTC) #6
tjblasi
6 years, 1 month ago (2014-11-12 18:27:04 UTC) #8
Message was sent while issue was closed.
FYI, README.md still recommends using [getUsage] rather than [usage].

Powered by Google App Engine
This is Rietveld 408576698