Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 630763004: Unify Entry and EntryImpl classes (Closed)

Created:
6 years, 2 months ago by Brian Wilkerson
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Additional Clean-up #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+991 lines, -1047 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 1 139 chunks +917 lines, -971 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 70 chunks +74 lines, -76 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
6 years, 2 months ago (2014-10-06 19:25:47 UTC) #2
scheglov
LGTM https://codereview.chromium.org/630763004/diff/20001/pkg/analyzer/test/generated/engine_test.dart File pkg/analyzer/test/generated/engine_test.dart (right): https://codereview.chromium.org/630763004/diff/20001/pkg/analyzer/test/generated/engine_test.dart#newcode2710 pkg/analyzer/test/generated/engine_test.dart:2710: class DartEntryImplTest extends EngineTestCase { You could also ...
6 years, 2 months ago (2014-10-06 19:30:23 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/630763004/diff/20001/pkg/analyzer/test/generated/engine_test.dart File pkg/analyzer/test/generated/engine_test.dart (right): https://codereview.chromium.org/630763004/diff/20001/pkg/analyzer/test/generated/engine_test.dart#newcode2710 pkg/analyzer/test/generated/engine_test.dart:2710: class DartEntryImplTest extends EngineTestCase { Done
6 years, 2 months ago (2014-10-06 19:43:27 UTC) #4
Brian Wilkerson
6 years, 2 months ago (2014-10-06 19:43:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40944 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698