Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 630743002: Remove cache entry copying (Closed)

Created:
6 years, 2 months ago by Brian Wilkerson
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove cache entry copying. This also removes the extractContext/mergeContext methods, but I don't believe that anyone is depending on them. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -816 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 115 chunks +266 lines, -666 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 15 chunks +0 lines, -150 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 2 months ago (2014-10-06 13:22:29 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-06 13:46:25 UTC) #3
Brian Wilkerson
6 years, 2 months ago (2014-10-06 16:06:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698