Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 630513002: Uncomment and clean up all_the_rest.dart tests. (Closed)

Created:
6 years, 2 months ago by scheglov
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Uncomment and clean up all_the_rest.dart tests. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -210 lines) Patch
M pkg/analyzer/lib/src/generated/html.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +196 lines, -1 line 0 comments Download
A pkg/analyzer/lib/src/generated/testing/html_factory.dart View 1 chunk +84 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 32 chunks +299 lines, -208 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 2 months ago (2014-10-03 22:05:00 UTC) #1
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-03 22:09:01 UTC) #2
scheglov
6 years, 2 months ago (2014-10-03 22:09:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40906 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698