Issue 630163004: Add SingleStringLiteral with accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 630163004: Add SingleStringLiteral with accessors. (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add SingleStringLiteral with accessors. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40949

Patch Set 2 : Add GeneralizingAstVisitor.visitSingleStringLiteral #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+218 lines, -47 lines)			Patch
M	pkg/analyzer/lib/src/generated/ast.dart	View	1	9 chunks	+100 lines, -27 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/ast_test.dart	View		4 chunks	+109 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/630163004/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/630163004/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode16232 pkg/analyzer/lib/src/generated/ast.dart:16232: abstract class SingleStringLiteral extends StringLiteral { GeneralizingAstVisitor should ...

6 years, 2 months ago (2014-10-06 21:59:26 UTC) #2

scheglov

Committed patchset #2 (id:20001) manually as 40949 (presubmit successful).

6 years, 2 months ago (2014-10-07 00:51:20 UTC) #3

scheglov

6 years, 2 months ago (2014-10-07 00:53:34 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/630163004/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/630163004/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/ast.dart:16232: abstract class
SingleStringLiteral extends StringLiteral {
On 2014/10/06 21:59:26, Brian Wilkerson wrote:
> GeneralizingAstVisitor should have a visitSingleStringLiteral method added to
> it.

Done.

Expand Messages | Collapse Messages

Issue 630163004: Add SingleStringLiteral with accessors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add GeneralizingAstVisitor.visitSingleStringLiteral #

Messages