Issue 630043002: Fix assertion failure in range analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 630043002: Fix assertion failure in range analysis. (Closed)

Created:
6 years, 2 months ago by Florian Schneider

Modified:
6 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix assertion failure in range analysis. The resulting range was correct, but not precise, as expected (too large by a constant) BUG=dartbug.com/21245 TEST=tests/language/vm/regress_21245_test.dart R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40932

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -10 lines)			Patch
	M	runtime/vm/flow_graph_range_analysis.cc	View		4 chunks	+4 lines, -10 lines	0 comments	Download
	A	tests/language/vm/regress_21245_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Florian Schneider

6 years, 2 months ago (2014-10-06 14:52:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r40932 (presubmit successful).